ci: add frontend build check to catch broken builds#65
Open
will-yuponce-db wants to merge 2 commits intomainfrom
Open
ci: add frontend build check to catch broken builds#65will-yuponce-db wants to merge 2 commits intomainfrom
will-yuponce-db wants to merge 2 commits intomainfrom
Conversation
Recent code was committed that broke the UI because vite build was never run in CI. This adds a parallel frontend-build job that runs `yarn build` to verify the frontend compiles successfully. Co-authored-by: Cursor <cursoragent@cursor.com>
- Remove redundant string literal comparisons in uc-asset-lookup-dialog (enum values already match the strings, so TS narrowing flagged them) - Widen navigateToEntity param to EnrichedSemanticLink for entity_name access - Allow empty string in assignTargetType state union type Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend-buildjob to CI that runsyarn build(vite build) in parallel with existing jobsTest plan
Frontend Build Checkjob appears in GitHub Actionsneeds)Made with Cursor